]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
clk: qcom: regmap-divider: convert from divider_ro_round_rate() to divider_ro_determi...
authorBrian Masney <bmasney@redhat.com>
Thu, 8 Jan 2026 21:16:33 +0000 (16:16 -0500)
committerBjorn Andersson <andersson@kernel.org>
Fri, 16 Jan 2026 21:18:25 +0000 (15:18 -0600)
The divider_ro_round_rate() function is now deprecated, so let's migrate
to divider_ro_determine_rate() instead so that this deprecated API can
be removed.

Note that when the main function itself was migrated to use
determine_rate, this was mistakenly converted to:

    req->rate = divider_round_rate(...)

This is invalid in the case when an error occurs since it can set the
rate to a negative value.

Fixes: b6f90511c165 ("clk: qcom: regmap-divider: convert from round_rate() to determine_rate()")
Signed-off-by: Brian Masney <bmasney@redhat.com>
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260108-clk-divider-round-rate-v1-15-535a3ed73bf3@redhat.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/clk/qcom/clk-regmap-divider.c

index 4f5395f0ab6d0ed8cebbb32cc231063932ba85a1..af9c01dd785372166122224e717c119a2365f4e1 100644 (file)
@@ -26,12 +26,8 @@ static int div_ro_determine_rate(struct clk_hw *hw,
        val >>= divider->shift;
        val &= BIT(divider->width) - 1;
 
-       req->rate = divider_ro_round_rate(hw, req->rate,
-                                         &req->best_parent_rate, NULL,
-                                         divider->width,
-                                         CLK_DIVIDER_ROUND_CLOSEST, val);
-
-       return 0;
+       return divider_ro_determine_rate(hw, req, NULL, divider->width,
+                                        CLK_DIVIDER_ROUND_CLOSEST, val);
 }
 
 static int div_determine_rate(struct clk_hw *hw, struct clk_rate_request *req)