ovl: don't set the superblock's errseq_t manually

Since commit 5679897eb104 ("vfs: make sync_filesystem return errors from
->sync_fs"), the return value from sync_fs callback can be seen in
sync_filesystem(). Thus the errseq_set opreation can be removed here.

Depends-on: commit 5679897eb104 ("vfs: make sync_filesystem return errors from ->sync_fs")
Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>

diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index 06a231970cb57269dbd59ac88c6cc5b9fe85fd4f..fe511192f83cb0dd6b60f9078be64e38bc271c5c 100644 (file)
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -202,15 +202,9 @@ static int ovl_sync_fs(struct super_block *sb, int wait)
        int ret;
 
        ret = ovl_sync_status(ofs);
-       /*
-        * We have to always set the err, because the return value isn't
-        * checked in syncfs, and instead indirectly return an error via
-        * the sb's writeback errseq, which VFS inspects after this call.
-        */
-       if (ret < 0) {
-               errseq_set(&sb->s_wb_err, -EIO);
+
+       if (ret < 0)
                return -EIO;
-       }
 
        if (!ret)
                return ret;