]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
Warn about unicode column having non-unicode default. See #2079.
authorDiana Clarke <diana.joan.clarke@gmail.com>
Mon, 14 Mar 2011 18:34:44 +0000 (14:34 -0400)
committerDiana Clarke <diana.joan.clarke@gmail.com>
Mon, 14 Mar 2011 18:34:44 +0000 (14:34 -0400)
lib/sqlalchemy/schema.py

index a6c7544b1487a552cc1058c0c7aa40eee2b9946b..68e8179f94d0de3c437a946bb21ed2264d5c5728 100644 (file)
@@ -722,6 +722,14 @@ class Column(SchemaItem, expression.ColumnClause):
             if isinstance(self.default, (ColumnDefault, Sequence)):
                 args.append(self.default)
             else:
+                if getattr(self.type, '_warn_on_bytestring', False):
+                    # Py3K
+                    #if isinstance(self.default, bytes):
+                    # Py2K
+                    if isinstance(self.default, str):
+                    # end Py2K
+                        util.warn("Unicode column received non-unicode "
+                                  "default value.")                    
                 args.append(ColumnDefault(self.default))
 
         if self.server_default is not None: