]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: mctp: mctp_test_route_extaddr_input cleanup
authorMatt Johnston <matt@codeconstruct.com.au>
Thu, 10 Jul 2025 08:55:54 +0000 (16:55 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 15 Jul 2025 10:08:39 +0000 (12:08 +0200)
The sock was not being released. Other than leaking, the stale socket
will conflict with subsequent bind() calls in unrelated MCTP tests.

Fixes: 46ee16462fed ("net: mctp: test: Add extaddr routing output test")
Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
Link: https://patch.msgid.link/20250710-mctp-bind-v4-1-8ec2f6460c56@codeconstruct.com.au
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/mctp/test/route-test.c

index 7a398f41b6216afef72adecf118199753ed1bfea..12811032a2696167b4f319cbc9c81fef4cb2d951 100644 (file)
@@ -1164,8 +1164,6 @@ static void mctp_test_route_extaddr_input(struct kunit *test)
        rc = mctp_dst_input(&dst, skb);
        KUNIT_ASSERT_EQ(test, rc, 0);
 
-       mctp_test_dst_release(&dst, &tpq);
-
        skb2 = skb_recv_datagram(sock->sk, MSG_DONTWAIT, &rc);
        KUNIT_ASSERT_NOT_ERR_OR_NULL(test, skb2);
        KUNIT_ASSERT_EQ(test, skb2->len, len);
@@ -1179,8 +1177,8 @@ static void mctp_test_route_extaddr_input(struct kunit *test)
        KUNIT_EXPECT_EQ(test, cb2->halen, sizeof(haddr));
        KUNIT_EXPECT_MEMEQ(test, cb2->haddr, haddr, sizeof(haddr));
 
-       skb_free_datagram(sock->sk, skb2);
-       mctp_test_destroy_dev(dev);
+       kfree_skb(skb2);
+       __mctp_route_test_fini(test, dev, &dst, &tpq, sock);
 }
 
 static void mctp_test_route_gw_lookup(struct kunit *test)