]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/msm/dsi: Add check for devm_kstrdup()
authorHaoxiang Li <haoxiang_li2024@163.com>
Wed, 19 Feb 2025 04:07:12 +0000 (12:07 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Apr 2025 08:47:57 +0000 (10:47 +0200)
commit 52b3f0e118b1700e5c60ff676a1f522ce44fadc8 upstream.

Add check for the return value of devm_kstrdup() in
dsi_host_parse_dt() to catch potential exception.

Fixes: 958d8d99ccb3 ("drm/msm/dsi: parse vsync source from device tree")
Cc: stable@vger.kernel.org
Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/638297/
Link: https://lore.kernel.org/r/20250219040712.2598161-1-haoxiang_li2024@163.com
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/msm/dsi/dsi_host.c

index 7459fb8c51774688ce69be2bdd2d692cd48feb70..d22e01751f5eeb6762f1bbf4339416def72b3144 100644 (file)
@@ -1827,8 +1827,15 @@ static int dsi_host_parse_dt(struct msm_dsi_host *msm_host)
                        __func__, ret);
                goto err;
        }
-       if (!ret)
+       if (!ret) {
                msm_dsi->te_source = devm_kstrdup(dev, te_source, GFP_KERNEL);
+               if (!msm_dsi->te_source) {
+                       DRM_DEV_ERROR(dev, "%s: failed to allocate te_source\n",
+                               __func__);
+                       ret = -ENOMEM;
+                       goto err;
+               }
+       }
        ret = 0;
 
        if (of_property_read_bool(np, "syscon-sfpb")) {