]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
gpio: realtek-otto: fix GPIO line IRQ offset
authorSander Vanheule <sander@svanheule.net>
Thu, 28 Oct 2021 08:52:43 +0000 (10:52 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Nov 2021 10:04:37 +0000 (11:04 +0100)
[ Upstream commit 585a07079909ba9061ddd88214c36653e1aef71a ]

The irqchip uses one domain for all GPIO lines, so the line offset
should be determined w.r.t. the first line of the first port, not the
first line of the triggered port.

Fixes: 0d82fb1127fb ("gpio: Add Realtek Otto GPIO support")
Signed-off-by: Sander Vanheule <sander@svanheule.net>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpio/gpio-realtek-otto.c

index cb64fb5a51aa1e9f52a7c96618e6996c3365e27f..e0cbaa1ea22ec18c7ee22bbf9e47ac981e364e05 100644 (file)
@@ -206,7 +206,7 @@ static void realtek_gpio_irq_handler(struct irq_desc *desc)
                status = realtek_gpio_read_isr(ctrl, lines_done / 8);
                port_pin_count = min(gc->ngpio - lines_done, 8U);
                for_each_set_bit(offset, &status, port_pin_count) {
-                       irq = irq_find_mapping(gc->irq.domain, offset);
+                       irq = irq_find_mapping(gc->irq.domain, offset + lines_done);
                        generic_handle_irq(irq);
                }
        }