EAP-AKA: Use strdup instead of strlen + malloc + memcpy

While the copy is not used as a null terminated string, this can prevent
some static analyzers from complaining about non-issue.

Signed-hostap: Jouni Malinen <j@w1.fi>

diff --git a/src/eap_server/eap_server_aka.c b/src/eap_server/eap_server_aka.c
index 42cbdce404a1befdb0cbc689a5f5deb5f68c655b..0f25ffd83c6834837cf0c40b7eb398cacf9e5f22 100644 (file)
--- a/src/eap_server/eap_server_aka.c
+++ b/src/eap_server/eap_server_aka.c
@@ -133,14 +133,13 @@ static void * eap_aka_prime_init(struct eap_sm *sm)
                return NULL;
 
        data->eap_method = EAP_TYPE_AKA_PRIME;
-       data->network_name = os_malloc(os_strlen(network_name));
+       data->network_name = (u8 *) os_strdup(network_name);
        if (data->network_name == NULL) {
                os_free(data);
                return NULL;
        }
 
        data->network_name_len = os_strlen(network_name);
-       os_memcpy(data->network_name, network_name, data->network_name_len);
 
        data->state = IDENTITY;
        eap_aka_determine_identity(sm, data, 1, 0);