]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
usb: gadget: functionfs: use dma_buf_unmap_attachment_unlocked() helper
authorLiang Jie <liangjie@lixiang.com>
Fri, 14 Nov 2025 08:42:44 +0000 (16:42 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Nov 2025 14:13:52 +0000 (15:13 +0100)
Replace the open-coded dma_resv_lock()/dma_resv_unlock() around
dma_buf_unmap_attachment() in ffs_dmabuf_release() with the
dma_buf_unmap_attachment_unlocked() helper.

This aligns FunctionFS DMABUF unmap handling with the standard
DMA-BUF API, avoids duplicating locking logic and eases future
maintenance. No functional change.

Reviewed-by: fanggeng <fanggeng@lixiang.com>
Signed-off-by: Liang Jie <liangjie@lixiang.com>
Link: https://patch.msgid.link/20251114084246.2064845-1-buaajxlj@163.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/function/f_fs.c

index 47cfbe41fdff8dc2b662d2cf05c454c34096e7e5..7f8e566b1c57a2b13456fdd1bd61696a6aace6cf 100644 (file)
@@ -1306,9 +1306,7 @@ static void ffs_dmabuf_release(struct kref *ref)
        struct dma_buf *dmabuf = attach->dmabuf;
 
        pr_vdebug("FFS DMABUF release\n");
-       dma_resv_lock(dmabuf->resv, NULL);
-       dma_buf_unmap_attachment(attach, priv->sgt, priv->dir);
-       dma_resv_unlock(dmabuf->resv);
+       dma_buf_unmap_attachment_unlocked(attach, priv->sgt, priv->dir);
 
        dma_buf_detach(attach->dmabuf, attach);
        dma_buf_put(dmabuf);