]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemuMonitorOpen: Rework domain object refcounting
authorMichal Privoznik <mprivozn@redhat.com>
Wed, 27 Oct 2021 12:41:58 +0000 (14:41 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Fri, 12 Nov 2021 13:11:49 +0000 (14:11 +0100)
Similarly to one of previous commits, there's no need to
increment domain object refcounter before unlocking it. Any
number of lock and unlock calls over domain object has no effect
on the refcounter.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_monitor.c

index 92dd4e75575fed4f51af2ab4c2444eaaffdbbb17..9ad8ffa422ac6efa47e15f493b83a4274076ea8c 100644 (file)
@@ -769,10 +769,6 @@ qemuMonitorOpen(virDomainObj *vm,
 
     timeout += QEMU_DEFAULT_MONITOR_WAIT;
 
-    /* Hold an extra reference because we can't allow 'vm' to be
-     * deleted until the monitor gets its own reference. */
-    virObjectRef(vm);
-
     if (config->type != VIR_DOMAIN_CHR_TYPE_UNIX) {
         virReportError(VIR_ERR_INTERNAL_ERROR,
                        _("unable to handle monitor type: %s"),
@@ -798,7 +794,6 @@ qemuMonitorOpen(virDomainObj *vm,
  cleanup:
     if (!ret)
         VIR_FORCE_CLOSE(fd);
-    virObjectUnref(vm);
     return ret;
 }