]> git.ipfire.org Git - thirdparty/kea.git/commitdiff
[2541] Update in-code comment
authorJelte Jansen <jelte@isc.org>
Wed, 12 Dec 2012 22:25:29 +0000 (23:25 +0100)
committerJelte Jansen <jelte@isc.org>
Wed, 12 Dec 2012 22:25:29 +0000 (23:25 +0100)
src/lib/datasrc/database.cc

index 62da2e0d44bd103524b63c2a16f62cf9d5e132b9..b65bc08f43a2cad5150164734da40d441fe8e5c4 100644 (file)
@@ -1397,11 +1397,8 @@ public:
                 logger.info(DATASRC_DATABASE_UPDATER_ROLLBACK)
                     .arg(zone_name_).arg(zone_class_).arg(db_name_);
             } catch (const DataSourceError& e) {
-                // We generally expect that rollback always succeeds, and
-                // it should in fact succeed in a way we execute it.  But
-                // as the public API allows rollback() to fail and
-                // throw, we should expect it.  Obviously we cannot re-throw
-                // it.  The best we can do is to log it as a critical error.
+                // See The destructor ~TransactionHolder() for the
+                // reason to catch this.
                 logger.error(DATASRC_DATABASE_UPDATER_ROLLBACKFAIL)
                     .arg(zone_name_).arg(zone_class_).arg(db_name_)
                     .arg(e.what());