]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: hotplug: ensure address generation for vfio-ccw
authorBjoern Walk <bwalk@linux.ibm.com>
Mon, 28 Oct 2019 08:06:13 +0000 (09:06 +0100)
committerJán Tomko <jtomko@redhat.com>
Tue, 12 Nov 2019 15:43:14 +0000 (16:43 +0100)
When attaching a mediated host device of model vfio-ccw without
specifying a guest-address, none is generated by libvirt. Let's fix this
and make sure to generate a device address during live-hotplug.

Reviewed-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
Signed-off-by: Bjoern Walk <bwalk@linux.ibm.com>
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_hotplug.c

index 374c85042d2e4681119e46d19626b193f93b3413..811ad952c537f36b036fdbc4d5ddaa31e7884580 100644 (file)
@@ -2799,7 +2799,13 @@ qemuDomainAttachMediatedDevice(virQEMUDriverPtr driver,
         if (qemuDomainEnsurePCIAddress(vm, &dev, driver) < 0)
             return -1;
         break;
-    case VIR_MDEV_MODEL_TYPE_VFIO_CCW:
+    case VIR_MDEV_MODEL_TYPE_VFIO_CCW: {
+        const char *devName = hostdev->source.subsys.u.mdev.uuidstr;
+        bool releaseaddr = false;
+
+        if (qemuDomainEnsureVirtioAddress(&releaseaddr, vm, &dev, devName) < 0)
+            return -1;
+    }   break;
     case VIR_MDEV_MODEL_TYPE_LAST:
         break;
     }