gpio: mpsse: drop redundant device reference

Driver core holds a reference to the USB interface and its parent USB
device while the interface is bound to a driver and there is no need to
take additional references unless the structures are needed after
disconnect.

Drop the redundant device reference to reduce cargo culting, make it
easier to spot drivers where an extra reference is needed, and reduce
the risk of memory leaks when drivers fail to release it.

Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Linus Walleij <linusw@kernel.org>
Link: https://patch.msgid.link/20260305124945.10781-1-johan@kernel.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

diff --git a/drivers/gpio/gpio-mpsse.c b/drivers/gpio/gpio-mpsse.c
index 12191aeb656686d4ef90ae95ded6c25571154af3..a859deab2bca80a8e995fe4f140f0c79dc698a77 100644 (file)
--- a/drivers/gpio/gpio-mpsse.c
+++ b/drivers/gpio/gpio-mpsse.c
@@ -548,13 +548,6 @@ static void gpio_mpsse_ida_remove(void *data)
        ida_free(&gpio_mpsse_ida, priv->id);
 }
 
-static void gpio_mpsse_usb_put_dev(void *data)
-{
-       struct mpsse_priv *priv = data;
-
-       usb_put_dev(priv->udev);
-}
-
 static int mpsse_init_valid_mask(struct gpio_chip *chip,
                                 unsigned long *valid_mask,
                                 unsigned int ngpios)
@@ -598,11 +591,7 @@ static int gpio_mpsse_probe(struct usb_interface *interface,
 
        INIT_LIST_HEAD(&priv->workers);
 
-       priv->udev = usb_get_dev(interface_to_usbdev(interface));
-       err = devm_add_action_or_reset(dev, gpio_mpsse_usb_put_dev, priv);
-       if (err)
-               return err;
-
+       priv->udev = interface_to_usbdev(interface);
        priv->intf = interface;
        priv->intf_id = interface->cur_altsetting->desc.bInterfaceNumber;