]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
rust: module_param: add missing newline to pr_warn_once
authorKenny Glowner <sisyphuscode0311@gmail.com>
Thu, 21 May 2026 16:14:05 +0000 (11:14 -0500)
committerSami Tolvanen <samitolvanen@google.com>
Thu, 4 Jun 2026 16:42:34 +0000 (16:42 +0000)
Add a trailing newline ('\n') to the pr_warn_once! call in set_param to
ensure the kernel ring buffer flushes the message correctly and
prevents log line smearing.

Signed-off-by: Kenny Glowner <SisyphusCode0311@gmail.com>
Suggested-by: Miguel Ojeda <ojeda@kernel.org>
Link: https://github.com/Rust-for-Linux/linux/issues/1139
[Sami: Updated the commit message as we use pr_warn_once now.]
Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
rust/kernel/module_param.rs

index dd6d663a0a3c4819d4242e4767e60acfc6d8848b..6541af218390c36a057cf5647aaac6fc985420f5 100644 (file)
@@ -62,7 +62,7 @@ where
     // NOTE: If we start supporting arguments without values, val _is_ allowed
     // to be null here.
     if val.is_null() {
-        crate::pr_warn_once!("Null pointer passed to `module_param::set_param`");
+        crate::pr_warn_once!("Null pointer passed to `module_param::set_param`\n");
         return EINVAL.to_errno();
     }