]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virresctrl: fix starting VMs with cputune.memorytune specified
authorPavel Hrdina <phrdina@redhat.com>
Mon, 21 Jun 2021 11:03:51 +0000 (13:03 +0200)
committerPavel Hrdina <phrdina@redhat.com>
Mon, 21 Jun 2021 11:17:18 +0000 (13:17 +0200)
When removing check for return value of VIR_EXPAND_N this place was
incorrectly modified causing failure to start a VM with cputune
memorytune configured with useless error message:

    error: Failed to start domain 'vm1'
    error: An error occurred, but the cause is unknown

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1973094
Fixes: 7d2fd6ef0163a939adb7ce0f0fad3b7654c340de
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/util/virresctrl.c

index a03113d4d692e1e37db09b1323644e8dbd7ffb02..35e92022dbde25e0c13eeac7182f98ea8178d57f 100644 (file)
@@ -1437,7 +1437,6 @@ virResctrlAllocParseProcessMemoryBandwidth(virResctrlInfo *resctrl,
     if (alloc->mem_bw->nbandwidths <= id) {
         VIR_EXPAND_N(alloc->mem_bw->bandwidths, alloc->mem_bw->nbandwidths,
                      id - alloc->mem_bw->nbandwidths + 1);
-        return -1;
     }
     if (!alloc->mem_bw->bandwidths[id])
         alloc->mem_bw->bandwidths[id] = g_new0(unsigned int, 1);