Fix heap-buffer-overflow in pap_auth_pbkdf2_parse()

==3061536==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6100000053f9 at pc 0x7f3eb4ff6bbe bp 0x7fff630b7770 sp 0x7fff630b7768
READ of size 1 at 0x6100000053f9 thread T0
    #0 0x7f3eb4ff6bbd in strlcpy /home/jpereira/Devel/FreeRADIUS/freeradius-server-v3.2.x.git-linux/src/lib/strlcpy.c:56:10

diff --git a/src/modules/rlm_pap/rlm_pap.c b/src/modules/rlm_pap/rlm_pap.c
index b4fbc2a3317c78aa9a89e816d08a97269f71733b..463ff66b7100bf15656efb90b55adc28e21e5e1f 100644 (file)
--- a/src/modules/rlm_pap/rlm_pap.c
+++ b/src/modules/rlm_pap/rlm_pap.c
@@ -904,7 +904,9 @@ static inline rlm_rcode_t CC_HINT(nonnull) pap_auth_pbkdf2_parse(REQUEST *reques
                goto finish;
        }
 
-       strlcpy(hash_token, (char const *)p, (q - p) + 1);
+       memcpy(hash_token, (char const *)p, (q - p));
+       hash_token[q - p] = '\0';
+
        digest_type = fr_str2int(hash_names, hash_token, -1);
        switch (digest_type) {
        case PW_SSHA1_PASSWORD: