]> git.ipfire.org Git - thirdparty/xtables-addons.git/commitdiff
pknock: reduce indent in remove_rule
authorJan Engelhardt <jengelh@medozas.de>
Wed, 7 Oct 2009 21:59:05 +0000 (23:59 +0200)
committerJan Engelhardt <jengelh@medozas.de>
Wed, 7 Oct 2009 21:59:05 +0000 (23:59 +0200)
extensions/xt_pknock.c

index 394a45ecc0dd71d01a5db9c12cb86c0fe66cc458..7e50162309eb3bdcffb69915e03cec011334e26e 100644 (file)
@@ -504,27 +504,28 @@ remove_rule(struct xt_pknock_mtinfo *info)
                pr_debug("(N) rule not found: %s.\n", info->rule_name);
                return;
        }
-       if (rule != NULL && rule->ref_count == 0) {
-               hashtable_for_each_safe(pos, n, rule->peer_head, peer_hashsize, i) {
-                       peer = list_entry(pos, struct peer, head);
-
-                       if (peer != NULL) {
-                               pk_debug("DELETED", peer);
-                               list_del(pos);
-                               kfree(peer);
-                       }
-               }
+       if (rule == NULL || rule->ref_count != 0)
+               return;
 
-               if (rule->status_proc != NULL)
-                       remove_proc_entry(info->rule_name, pde);
-               pr_debug("(D) rule deleted: %s.\n", rule->rule_name);
-               if (timer_pending(&rule->timer))
-                       del_timer(&rule->timer);
+       hashtable_for_each_safe(pos, n, rule->peer_head, peer_hashsize, i) {
+               peer = list_entry(pos, struct peer, head);
 
-               list_del(&rule->head);
-               kfree(rule->peer_head);
-               kfree(rule);
+               if (peer != NULL) {
+                       pk_debug("DELETED", peer);
+                       list_del(pos);
+                       kfree(peer);
+               }
        }
+
+       if (rule->status_proc != NULL)
+               remove_proc_entry(info->rule_name, pde);
+       pr_debug("(D) rule deleted: %s.\n", rule->rule_name);
+       if (timer_pending(&rule->timer))
+               del_timer(&rule->timer);
+
+       list_del(&rule->head);
+       kfree(rule->peer_head);
+       kfree(rule);
 }
 
 /**