]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
sdbox: Fix panic due to leaked mail_index_view if sync fails
authorTimo Sirainen <timo.sirainen@open-xchange.com>
Sun, 5 Feb 2023 18:51:12 +0000 (20:51 +0200)
committermarkus.valentin <markus.valentin@open-xchange.com>
Tue, 28 Feb 2023 12:09:54 +0000 (12:09 +0000)
Fixes:
Panic: Leaked view for index .../dbox-Mails/dovecot.index: Opened in mail-index-sync.c:445

src/lib-storage/index/dbox-single/sdbox-sync.c

index c8a0b549a9e8139c4076f704fdeaa64ab3819bac..1e8879ecf785246d6a581a8dd8f8de31227ee721 100644 (file)
@@ -279,8 +279,8 @@ int sdbox_sync_finish(struct sdbox_sync_context **_ctx, bool success)
                        ret = -1;
                } else {
                        dbox_sync_expunge_files(ctx);
-                       mail_index_view_close(&ctx->sync_view);
                }
+               mail_index_view_close(&ctx->sync_view);
        } else {
                mail_index_sync_rollback(&ctx->index_sync_ctx);
        }