]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
qlcnic: Fix error code in probe
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 16 Dec 2020 08:38:04 +0000 (11:38 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Dec 2020 10:51:28 +0000 (11:51 +0100)
[ Upstream commit 0d52848632a357948028eab67ff9b7cc0c12a0fb ]

Return -EINVAL if we can't find the correct device.  Currently it
returns success.

Fixes: 13159183ec7a ("qlcnic: 83xx base driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/X9nHbMqEyI/xPfGd@mwanda
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c

index c07438db30ba1b287639ce6f12d5d032f567d4f1..f2e5f494462b3a14510a285dd8a263cb14207dbd 100644 (file)
@@ -2509,6 +2509,7 @@ qlcnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
                qlcnic_sriov_vf_register_map(ahw);
                break;
        default:
+               err = -EINVAL;
                goto err_out_free_hw_res;
        }