]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ublk: drop ublk_ctrl_start_recovery() header argument
authorCaleb Sander Mateos <csander@purestorage.com>
Fri, 30 Jan 2026 17:14:14 +0000 (10:14 -0700)
committerJens Axboe <axboe@kernel.dk>
Sat, 31 Jan 2026 13:36:11 +0000 (06:36 -0700)
ublk_ctrl_start_recovery() only uses its const struct ublksrv_ctrl_cmd *
header argument to log the dev_id. But this value is already available
in struct ublk_device's ub_number field. So log ub_number instead and
drop the unused header argument.

Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/ublk_drv.c

index 8122b012a7ae8d5f4076b666d104ccc21f95165a..60d07480a24c2723ef2f45b14cded6effa1bfd7c 100644 (file)
@@ -4872,8 +4872,7 @@ static int ublk_ctrl_set_params(struct ublk_device *ub,
        return ret;
 }
 
-static int ublk_ctrl_start_recovery(struct ublk_device *ub,
-               const struct ublksrv_ctrl_cmd *header)
+static int ublk_ctrl_start_recovery(struct ublk_device *ub)
 {
        int ret = -EINVAL;
 
@@ -4902,7 +4901,7 @@ static int ublk_ctrl_start_recovery(struct ublk_device *ub,
                ret = -EBUSY;
                goto out_unlock;
        }
-       pr_devel("%s: start recovery for dev id %d.\n", __func__, header->dev_id);
+       pr_devel("%s: start recovery for dev id %d\n", __func__, ub->ub_number);
        init_completion(&ub->completion);
        ret = 0;
  out_unlock:
@@ -5283,7 +5282,7 @@ static int ublk_ctrl_uring_cmd(struct io_uring_cmd *cmd,
                ret = ublk_ctrl_set_params(ub, &header);
                break;
        case UBLK_CMD_START_USER_RECOVERY:
-               ret = ublk_ctrl_start_recovery(ub, &header);
+               ret = ublk_ctrl_start_recovery(ub);
                break;
        case UBLK_CMD_END_USER_RECOVERY:
                ret = ublk_ctrl_end_recovery(ub, &header);