]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
qga: Fix VSS provider GetSnapshotProperties return value
authorElizabeth Ashurov <eashurov@redhat.com>
Wed, 11 Feb 2026 10:17:44 +0000 (12:17 +0200)
committerKostiantyn Kostiuk <kkostiuk@redhat.com>
Wed, 18 Feb 2026 09:27:57 +0000 (11:27 +0200)
GetSnapshotProperties() returned VSS_E_OBJECT_NOT_FOUND causing
"Snapshot id not found" errors during VSS operations.

Any error in this function causes a similar error in Windows VSS,
so we must return S_OK there.

Signed-off-by: Elizabeth Ashurov <eashurov@redhat.com>
Reviewed-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
Link: https://lore.kernel.org/qemu-devel/20260211101744.757548-2-eashurov@redhat.com
Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
qga/vss-win32/provider.cpp

index a102a23fbf1818b1d0ac073f37323c4b6775dc55..2b5c6f8e8ecd31e99dd429e4828790595b373398 100644 (file)
@@ -263,7 +263,7 @@ STDMETHODIMP CQGAVssProvider::SetContext(LONG lContext)
 STDMETHODIMP CQGAVssProvider::GetSnapshotProperties(
     VSS_ID SnapshotId, VSS_SNAPSHOT_PROP *pProp)
 {
-    return VSS_E_OBJECT_NOT_FOUND;
+    return S_OK;
 }
 
 STDMETHODIMP CQGAVssProvider::Query(