]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
Use virNWFilterBindingObjEndAPI() more
authorMichal Privoznik <mprivozn@redhat.com>
Wed, 10 Nov 2021 08:57:42 +0000 (09:57 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Thu, 11 Nov 2021 10:27:24 +0000 (11:27 +0100)
Instead of explicit virObjectUnlock(obj) + virObjectUnref(obj)
combo the virNWFilterBindingObjEndAPI() can be used.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
src/conf/virnwfilterbindingobjlist.c

index 470a30ca9047f771d2276cd2b67ab69d9511382c..212cca2265217589702353ca58822fb0f50a466c 100644 (file)
@@ -114,11 +114,8 @@ virNWFilterBindingObjListFindByPortDev(virNWFilterBindingObjList *bindings,
     obj = virNWFilterBindingObjListFindByPortDevLocked(bindings, name);
     virObjectRWUnlock(bindings);
 
-    if (obj && virNWFilterBindingObjGetRemoving(obj)) {
-        virObjectUnlock(obj);
-        virObjectUnref(obj);
-        obj = NULL;
-    }
+    if (obj && virNWFilterBindingObjGetRemoving(obj))
+        virNWFilterBindingObjEndAPI(&obj);
 
     return obj;
 }
@@ -407,8 +404,7 @@ virNWFilterBindingObjListFilter(virNWFilterBindingObj ***list,
          */
         if (virNWFilterBindingObjGetRemoving(binding) ||
             (filter && !filter(conn, def))) {
-            virObjectUnlock(binding);
-            virObjectUnref(binding);
+            virNWFilterBindingObjEndAPI(&binding);
             VIR_DELETE_ELEMENT(*list, i, *nbindings);
             continue;
         }