]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
btrfs: output extra debug info if we failed to find an inline backref
authorQu Wenruo <wqu@suse.com>
Tue, 1 Aug 2023 11:02:28 +0000 (19:02 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 23 Sep 2023 08:47:03 +0000 (10:47 +0200)
[ Upstream commit 7f72f50547b7af4ddf985b07fc56600a4deba281 ]

[BUG]
Syzbot reported several warning triggered inside
lookup_inline_extent_backref().

[CAUSE]
As usual, the reproducer doesn't reliably trigger locally here, but at
least we know the WARN_ON() is triggered when an inline backref can not
be found, and it can only be triggered when @insert is true. (I.e.
inserting a new inline backref, which means the backref should already
exist)

[ENHANCEMENT]
After the WARN_ON(), dump all the parameters and the extent tree
leaf to help debug.

Link: https://syzkaller.appspot.com/bug?extid=d6f9ff86c1d804ba2bc6
Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/btrfs/extent-tree.c

index e59987385673f894688c9b51d13da4b31bb45ae4..deb01e59da027721a433acb81e578c7d3c81e679 100644 (file)
@@ -1703,6 +1703,11 @@ again:
                err = -ENOENT;
                goto out;
        } else if (WARN_ON(ret)) {
+               btrfs_print_leaf(path->nodes[0]);
+               btrfs_err(fs_info,
+"extent item not found for insert, bytenr %llu num_bytes %llu parent %llu root_objectid %llu owner %llu offset %llu",
+                         bytenr, num_bytes, parent, root_objectid, owner,
+                         offset);
                err = -EIO;
                goto out;
        }