]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
homectl: trivial simplification
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Wed, 10 Dec 2025 14:48:48 +0000 (15:48 +0100)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Tue, 13 Jan 2026 16:59:54 +0000 (17:59 +0100)
src/home/homectl.c

index 6112a3a07c4f909249589391c78c0464dd5c158f..ceb7fae7ee00f653d3bc65e0138fd6be4d3b9480 100644 (file)
@@ -4944,18 +4944,13 @@ static int parse_argv(int argc, char *argv[]) {
                         break;
 
                 case ARG_KEY_NAME:
-                        if (isempty(optarg)) {
-                                arg_key_name = mfree(arg_key_name);
-                                return 0;
-                        }
-
-                        if (!filename_is_valid(optarg))
-                                return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "Specified key name not valid: %s", optarg);
+                        if (!isempty(optarg) && !filename_is_valid(optarg))
+                                return log_error_errno(SYNTHETIC_ERRNO(EINVAL),
+                                                       "Parameter for --key-name= not a valid filename: %s", optarg);
 
-                        r = free_and_strdup_warn(&arg_key_name, optarg);
+                        r = free_and_strdup_warn(&arg_key_name, empty_to_null(optarg));
                         if (r < 0)
                                 return r;
-
                         break;
 
                 case ARG_SEIZE: