]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
auth.idl: make sure ndr_{push,pull}_auth_SidAttr() is never used
authorStefan Metzmacher <metze@samba.org>
Tue, 28 Jan 2025 18:49:23 +0000 (19:49 +0100)
committerStefan Metzmacher <metze@samba.org>
Fri, 14 Feb 2025 14:21:32 +0000 (14:21 +0000)
auth_SidAttr is currently not used for any IPC traffic,
with this change demonstrates that and makes sure it
stays that way.

It means we are free to change auth_SidAttr without the
need to change any ipc protocol version.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
librpc/idl/auth.idl
librpc/ndr/ndr_auth.c

index ab5675ef8c56f3b215565103414812957dd46e68..214f48185f29f95686a45477fa220cc8e621777f 100644 (file)
@@ -109,14 +109,14 @@ interface auth
         * resource groups and resource groups in other domains are always
         * discarded.
         */
-       typedef enum {
+       typedef [nopush,nopull] enum {
                AUTH_GROUP_INCLUSION_INVALID = 0, /* require invalid values to be handled. */
                AUTH_INCLUDE_RESOURCE_GROUPS = 2,
                AUTH_INCLUDE_RESOURCE_GROUPS_COMPRESSED = 3,
                AUTH_EXCLUDE_RESOURCE_GROUPS = 4
        } auth_group_inclusion;
 
-       typedef [public] struct {
+       typedef [nopush,nopull] struct {
                dom_sid sid;
                security_GroupAttrs attrs;
        } auth_SidAttr;
index 0600586ed164ba9f9dc49a20a81ed3179caef0ce..b60d8bff4b073b956e4af602364c042de2c0ac9f 100644 (file)
@@ -41,4 +41,16 @@ _PUBLIC_ enum ndr_err_code ndr_push_cli_credentials(struct ndr_push *ndr, ndr_fl
        return ndr_push_pointer(ndr, ndr_flags, NULL);
 }
 
+_PUBLIC_ enum ndr_err_code ndr_push_auth_SidAttr(struct ndr_push *ndr, ndr_flags_type ndr_flags, const struct auth_SidAttr *r)
+{
+       return ndr_push_error(ndr,
+                             NDR_ERR_INVALID_POINTER,
+                             "ndr_push_auth_SidAttr not supported");
+}
 
+_PUBLIC_ enum ndr_err_code ndr_pull_auth_SidAttr(struct ndr_pull *ndr, ndr_flags_type ndr_flags, struct auth_SidAttr *r)
+{
+       return ndr_pull_error(ndr,
+                             NDR_ERR_INVALID_POINTER,
+                             "ndr_pull_auth_SidAttr not supported");
+}