]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virnetworkobj: Free retval of virNetworkObjGetPortStatusDir()
authorMichal Privoznik <mprivozn@redhat.com>
Tue, 9 Jul 2019 14:46:31 +0000 (16:46 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Fri, 12 Jul 2019 14:19:43 +0000 (16:19 +0200)
The virNetworkObjGetPortStatusDir() function allocates a memory
to construct a path. None of the callers free it leading to a
memleak.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
src/conf/virnetworkobj.c

index 12cefebaa8010b67f2f79b76bae450b589a02b72..45726e40162968943d02acc4f7bd8c29608ad416 100644 (file)
@@ -1627,7 +1627,7 @@ virNetworkObjAddPort(virNetworkObjPtr net,
 {
     int ret = -1;
     char uuidstr[VIR_UUID_STRING_BUFLEN];
-    char *dir = NULL;
+    VIR_AUTOFREE(char *) dir = NULL;
 
     virUUIDFormat(portdef->uuid, uuidstr);
 
@@ -1717,7 +1717,7 @@ int
 virNetworkObjDeleteAllPorts(virNetworkObjPtr net,
                             const char *stateDir)
 {
-    char *dir;
+    VIR_AUTOFREE(char *) dir = NULL;
     DIR *dh = NULL;
     struct dirent *de;
     int rc;
@@ -1843,7 +1843,7 @@ static int
 virNetworkObjLoadAllPorts(virNetworkObjPtr net,
                           const char *stateDir)
 {
-    char *dir;
+    VIR_AUTOFREE(char *) dir = NULL;
     DIR *dh = NULL;
     struct dirent *de;
     int ret = -1;