]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3:smbd: add a comment stating that file_close_user() is redundant for SMB2
authorRalph Boehme <slow@samba.org>
Thu, 30 Aug 2018 13:57:33 +0000 (15:57 +0200)
committerStefan Metzmacher <metze@samba.org>
Wed, 5 Sep 2018 11:31:44 +0000 (13:31 +0200)
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13549

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Sep  1 01:26:35 CEST 2018 on sn-devel-144

(cherry picked from commit 5d95f79f604d90c2646225a0f2470f05dd71e19e)

source3/smbd/smbXsrv_session.c

index d0622f3919aa4aa22f972673417967d95f6f993d..792c6efeb60c77e0874f49f939764366514e030a 100644 (file)
@@ -1660,6 +1660,12 @@ NTSTATUS smbXsrv_session_logoff(struct smbXsrv_session *session)
        session->status = NT_STATUS_USER_SESSION_DELETED;
 
        if (session->compat) {
+               /*
+                * For SMB2 this is a bit redundant as files are also close
+                * below via smb2srv_tcon_disconnect_all() -> ... ->
+                * smbXsrv_tcon_disconnect() -> close_cnum() ->
+                * file_close_conn().
+                */
                file_close_user(sconn, session->compat->vuid);
        }