]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm: rcar-du: Don't put reference to drm_device in rcar_du_remove()
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Tue, 23 Mar 2021 00:09:53 +0000 (02:09 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 15 Sep 2021 08:00:41 +0000 (10:00 +0200)
[ Upstream commit c29b6b0b126e9ee69a5d6339475e831a149295bd ]

The reference to the drm_device that was acquired by
devm_drm_dev_alloc() is released automatically by the devres
infrastructure. It must not be released manually, as that causes a
reference underflow..

Fixes: ea6aae151887 ("drm: rcar-du: Embed drm_device in rcar_du_device")
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/rcar-du/rcar_du_drv.c

index bfbff90588cbf647e3d9c6f110140c48e8811574..c22551c2facb1d3ec130bcb400819ef43013fe27 100644 (file)
@@ -556,8 +556,6 @@ static int rcar_du_remove(struct platform_device *pdev)
 
        drm_kms_helper_poll_fini(ddev);
 
-       drm_dev_put(ddev);
-
        return 0;
 }