Bug 1305671 - Bogus </a> after GitHub sign-in button

diff --git a/extensions/GitHubAuth/template/en/default/hook/account/auth/login-additional_methods.html.tmpl b/extensions/GitHubAuth/template/en/default/hook/account/auth/login-additional_methods.html.tmpl
index 17bcb3e426c634ceb9eb0680e0db83ce379c6be0..225b6f8a005a74956fba392c9cc64d34c4776afc 100644 (file)
--- a/extensions/GitHubAuth/template/en/default/hook/account/auth/login-additional_methods.html.tmpl
+++ b/extensions/GitHubAuth/template/en/default/hook/account/auth/login-additional_methods.html.tmpl
@@ -7,14 +7,12 @@
   #%]
 [% USE Bugzilla %]
 [% IF Param('user_info_class').split(',').contains('GitHubAuth') %]
-  <p>
-    <form method="post" action="[% urlbase FILTER html %]github.cgi">
-      <input type="hidden" name="github_secret" value="[% Bugzilla.github_secret FILTER html %]">
-      <input type="hidden" name="target_uri" value="[% Bugzilla.cgi.target_uri FILTER html %]">
-      <input type="image" src="extensions/GitHubAuth/web/images/github_sign_in.png"
+  <form method="post" action="[% urlbase FILTER html %]github.cgi">
+    <input type="hidden" name="github_secret" value="[% Bugzilla.github_secret FILTER html %]">
+    <input type="hidden" name="target_uri" value="[% Bugzilla.cgi.target_uri FILTER html %]">
+    <input type="image" src="extensions/GitHubAuth/web/images/github_sign_in.png"
            alt="Sign in with GitHub"
            title="Sign in with GitHub"
            width="185" height="25">
-    </form>
-  </p>
+  </form>
 [% END %]
\ No newline at end of file

diff --git a/extensions/GitHubAuth/template/en/default/hook/account/auth/login-small-additional_methods.html.tmpl b/extensions/GitHubAuth/template/en/default/hook/account/auth/login-small-additional_methods.html.tmpl
index f32b34a59c24fa81e653c740025fc5c83a5ef2e4..adcd9e067031dd82a262746fd2c83fcffce23856 100644 (file)
--- a/extensions/GitHubAuth/template/en/default/hook/account/auth/login-small-additional_methods.html.tmpl
+++ b/extensions/GitHubAuth/template/en/default/hook/account/auth/login-small-additional_methods.html.tmpl
@@ -24,7 +24,7 @@
       <input type="hidden" name="target_uri" value="[% Bugzilla.cgi.target_uri FILTER html %]">
         <input type="image" src="extensions/GitHubAuth/web/images/sign_in.png" height="22" width="75" align="absmiddle"
              alt="Sign in with GitHub"
-             title="Sign in with GitHub"></a> or
+             title="Sign in with GitHub"> or
     </form>
   </span>
 [% END %]