]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ext4: drop the TODO comment in ext4_es_insert_extent()
authorZhang Yi <yi.zhang@huawei.com>
Sat, 29 Nov 2025 10:32:46 +0000 (18:32 +0800)
committerTheodore Ts'o <tytso@mit.edu>
Sun, 18 Jan 2026 16:23:34 +0000 (11:23 -0500)
Now we have ext4_es_cache_extent() to cache on-disk extents instead of
ext4_es_insert_extent(), so drop the TODO comment.

Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
Reviewed-by: Baokun Li <libaokun1@huawei.com>
Message-ID: <20251129103247.686136-15-yi.zhang@huaweicloud.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/extents_status.c

index 0529c603ee88f9ca63a6db148707abfe584518c0..fc83e7e2ca9edb11677277985e70021a9c917393 100644 (file)
@@ -898,7 +898,8 @@ out:
 
 /*
  * ext4_es_insert_extent() adds information to an inode's extent
- * status tree.
+ * status tree. This interface is used for modifying extents. To cache
+ * on-disk extents, use ext4_es_cache_extent() instead.
  */
 void ext4_es_insert_extent(struct inode *inode, ext4_lblk_t lblk,
                           ext4_lblk_t len, ext4_fsblk_t pblk,
@@ -977,10 +978,6 @@ retry:
                }
                pending = err3;
        }
-       /*
-        * TODO: For cache on-disk extents, there is no need to increment
-        * the sequence counter, this requires future optimization.
-        */
        ext4_es_inc_seq(inode);
 error:
        write_unlock(&EXT4_I(inode)->i_es_lock);