]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
KVM: x86/mmu: Set shadow_accessed_mask for EPT even if A/D bits disabled
authorSean Christopherson <seanjc@google.com>
Fri, 11 Oct 2024 02:10:42 +0000 (19:10 -0700)
committerSean Christopherson <seanjc@google.com>
Wed, 30 Oct 2024 21:46:46 +0000 (14:46 -0700)
Now that KVM doesn't use shadow_accessed_mask to detect if hardware A/D
bits are enabled, set shadow_accessed_mask for EPT even when A/D bits
are disabled in hardware.  This will allow using shadow_accessed_mask for
software purposes, e.g. to preserve accessed status in a non-present SPTE
acros NUMA balancing, if something like that is ever desirable.

Link: https://lore.kernel.org/r/20241011021051.1557902-11-seanjc@google.com
Signed-off-by: Sean Christopherson <seanjc@google.com>
arch/x86/kvm/mmu/spte.c

index c9543625dda2aabb04dfaf8c2ebda8588c81ba81..e352d182131903d82dee4f9b18a06b2af1945f6a 100644 (file)
@@ -419,7 +419,7 @@ void kvm_mmu_set_ept_masks(bool has_ad_bits, bool has_exec_only)
        kvm_ad_enabled          = has_ad_bits;
 
        shadow_user_mask        = VMX_EPT_READABLE_MASK;
-       shadow_accessed_mask    = has_ad_bits ? VMX_EPT_ACCESS_BIT : 0ull;
+       shadow_accessed_mask    = VMX_EPT_ACCESS_BIT;
        shadow_dirty_mask       = has_ad_bits ? VMX_EPT_DIRTY_BIT : 0ull;
        shadow_nx_mask          = 0ull;
        shadow_x_mask           = VMX_EPT_EXECUTABLE_MASK;