selftests/bpf: test MSS value returned with bpf_tcp_gen_syncookie

One remaining difference between test_tcp_check_syncookie.sh and
btf_skc_cls_ingress is a small test on the mss value embedded in the
cookie generated with the eBPF helper.

Bring the corresponding test in btf_skc_cls_ingress.

Signed-off-by: Alexis Lothoré (eBPF Foundation) <alexis.lothore@bootlin.com>
Link: https://lore.kernel.org/r/20241020-syncookie-v2-5-2db240225fed@bootlin.com
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>

diff --git a/tools/testing/selftests/bpf/prog_tests/btf_skc_cls_ingress.c b/tools/testing/selftests/bpf/prog_tests/btf_skc_cls_ingress.c
index 29b946d84816e41e87f11d2400f5c9a68f91a126..cf15cc3be49105db2a47d5c8686db7236ce9dd09 100644 (file)
--- a/tools/testing/selftests/bpf/prog_tests/btf_skc_cls_ingress.c
+++ b/tools/testing/selftests/bpf/prog_tests/btf_skc_cls_ingress.c
@@ -27,6 +27,8 @@
 #define SERVER_ADDR_IPV4       "127.0.0.1"
 #define SERVER_ADDR_IPV6       "::1"
 #define SERVER_ADDR_DUAL       "::0"
+/* RFC791, 576 for minimal IPv4 datagram, minus 40 bytes of TCP header */
+#define MIN_IPV4_MSS           536
 
 static struct netns_obj *prepare_netns(struct test_btf_skc_cls_ingress *skel)
 {
@@ -71,6 +73,7 @@ static void reset_test(struct test_btf_skc_cls_ingress *skel)
        skel->bss->recv_cookie = 0;
        skel->bss->gen_cookie = 0;
        skel->bss->linum = 0;
+       skel->bss->mss = 0;
 }
 
 static void print_err_line(struct test_btf_skc_cls_ingress *skel)
@@ -183,6 +186,10 @@ static void run_test(struct test_btf_skc_cls_ingress *skel, bool gen_cookies,
                           "syncookie properly generated");
                ASSERT_EQ(skel->bss->gen_cookie, skel->bss->recv_cookie,
                          "matching syncookies on client and server");
+               ASSERT_GT(skel->bss->mss, MIN_IPV4_MSS,
+                         "MSS in cookie min value");
+               ASSERT_LT(skel->bss->mss, USHRT_MAX,
+                         "MSS in cookie max value");
        }
 
 done:

diff --git a/tools/testing/selftests/bpf/progs/test_btf_skc_cls_ingress.c b/tools/testing/selftests/bpf/progs/test_btf_skc_cls_ingress.c
index b38ca3c35994ba8e36d5108fa5f2f4053384368a..1cd1a1b72cb5e8f515302d452ca17727d8e2f58a 100644 (file)
--- a/tools/testing/selftests/bpf/progs/test_btf_skc_cls_ingress.c
+++ b/tools/testing/selftests/bpf/progs/test_btf_skc_cls_ingress.c
@@ -15,6 +15,7 @@ __u16 listen_tp_sport = 0;
 __u16 req_sk_sport = 0;
 __u32 recv_cookie = 0;
 __u32 gen_cookie = 0;
+__u32 mss = 0;
 __u32 linum = 0;
 
 #define LOG() ({ if (!linum) linum = __LINE__; })
@@ -46,6 +47,7 @@ static void test_syncookie_helper(void *iphdr, int iphdr_size,
                                LOG();
                } else {
                        gen_cookie = (__u32)mss_cookie;
+                       mss = mss_cookie >> 32;
                }
        } else if (gen_cookie) {
                /* It was in cookie mode */