/* SPDX-License-Identifier: LGPL-2.1-or-later */
#include <errno.h>
-#if HAVE_APPARMOR
-# include <sys/apparmor.h>
-#endif
#include <unistd.h>
#include "apparmor-setup.h"
#include "apparmor-util.h"
+#include "errno-util.h"
#include "fd-util.h"
#include "fileio.h"
#include "log.h"
#include "string-util.h"
#include "strv.h"
-#if HAVE_APPARMOR
-DEFINE_TRIVIAL_CLEANUP_FUNC_FULL(aa_policy_cache *, aa_policy_cache_unref, NULL);
-DEFINE_TRIVIAL_CLEANUP_FUNC_FULL(aa_features *, aa_features_unref, NULL);
-#endif
-
int mac_apparmor_setup(void) {
#if HAVE_APPARMOR
- _cleanup_(aa_policy_cache_unrefp) aa_policy_cache *policy_cache = NULL;
- _cleanup_(aa_features_unrefp) aa_features *features = NULL;
+ _cleanup_(sym_aa_policy_cache_unrefp) aa_policy_cache *policy_cache = NULL;
+ _cleanup_(sym_aa_features_unrefp) aa_features *features = NULL;
_cleanup_free_ char *current_profile = NULL, *cache_dir_path = NULL;
int r;
if (!mac_apparmor_use()) {
- log_debug("AppArmor either not supported by the kernel or disabled.");
+ log_debug("Skipping AppArmor initialization: not supported by the kernel or disabled.");
return 0;
}
- /* To enable LSM stacking a patch to the kernel is proposed to create a
- * per-LSM subdirectory to distinguish between the LSMs. Therefore, we
- * read the file from the LSM specific directory first and only if that
- * fails the one from the generic directory.
- */
+ r = dlopen_libapparmor();
+ if (ERRNO_IS_NEG_NOT_SUPPORTED(r))
+ return 0;
+ if (r < 0)
+ return log_error_errno(r, "Failed to load libapparmor: %m");
+
+ /* To honor LSM stacking, check per-LSM subdirectory first, and then the generic one as fallback. */
FOREACH_STRING(current_file, "/proc/self/attr/apparmor/current", "/proc/self/attr/current") {
r = read_one_line_file(current_file, ¤t_profile);
- if (r == -ENOENT)
- continue;
- else if (r < 0)
- log_warning_errno(r, "Failed to read current AppArmor profile from file %s, ignoring: %m", current_file);
- else
+ if (r >= 0)
break;
+ if (r != -ENOENT)
+ log_warning_errno(r, "Failed to read current AppArmor profile from '%s', ignoring: %m",
+ current_file);
}
if (!current_profile) {
- log_warning("Failed to get the current AppArmor profile of systemd from /proc/self/attr/apparmor/current or /proc/self/attr/current, ignoring.");
+ log_warning("Failed to get the current AppArmor profile of our own process, ignoring.");
return 0;
}
if (!streq(current_profile, "unconfined")) {
return 0;
}
- r = aa_features_new_from_kernel(&features);
+ r = sym_aa_features_new_from_kernel(&features);
if (r < 0) {
log_warning_errno(errno, "Failed to get the AppArmor feature set from the kernel, ignoring: %m");
return 0;
}
- cache_dir_path = aa_policy_cache_dir_path_preview(features, AT_FDCWD, "/etc/apparmor/earlypolicy");
+
+ cache_dir_path = sym_aa_policy_cache_dir_path_preview(features, AT_FDCWD, "/etc/apparmor/earlypolicy");
if (!cache_dir_path) {
- log_debug_errno(errno, "Failed to get the path of the early AppArmor policy cache directory.");
+ log_debug_errno(errno, "Failed to get the path of the early AppArmor policy cache directory, ignoring: %m");
return 0;
}
/* aa_policy_cache_new will internally use the same path as aa_policy_cache_dir_path_preview has returned. */
- r = aa_policy_cache_new(&policy_cache, features, AT_FDCWD, "/etc/apparmor/earlypolicy", 0);
+ r = sym_aa_policy_cache_new(&policy_cache, features, AT_FDCWD, "/etc/apparmor/earlypolicy", 0);
if (r < 0) {
- if (errno == ENOENT) {
- log_debug_errno(errno, "The early AppArmor policy cache directory %s does not exist.", cache_dir_path);
- return 0;
- }
- log_warning_errno(errno, "Failed to create a new AppArmor policy cache, ignoring: %m");
+ if (errno == ENOENT)
+ log_debug_errno(errno,
+ "The early AppArmor policy cache directory '%s' does not exist.",
+ cache_dir_path);
+ else
+ log_warning_errno(errno, "Failed to create a new AppArmor policy cache, ignoring: %m");
return 0;
}
- r = aa_policy_cache_replace_all(policy_cache, NULL);
+
+ r = sym_aa_policy_cache_replace_all(policy_cache, NULL);
if (r < 0) {
- log_warning_errno(errno, "Failed to load the profiles from the early AppArmor policy cache directory %s, ignoring: %m", cache_dir_path);
+ log_warning_errno(errno,
+ "Failed to load the profiles from the early AppArmor policy cache directory '%s', ignoring: %m",
+ cache_dir_path);
return 0;
}
- log_info("Successfully loaded all binary profiles from AppArmor early policy cache at %s.", cache_dir_path);
+ log_info("Successfully loaded all binary profiles from AppArmor early policy cache (%s).", cache_dir_path);
- r = aa_change_profile("systemd");
+ r = sym_aa_change_profile("systemd");
if (r < 0) {
if (errno == ENOENT)
- log_debug_errno(errno, "Failed to change to AppArmor profile 'systemd'. Please ensure that one of the binary profile files in policy cache directory %s contains a profile with that name.", cache_dir_path);
+ log_debug_errno(errno,
+ "Failed to change to AppArmor profile 'systemd'.\n"
+ "Please ensure that one of the binary profile files in policy cache directory '%s' contains a profile with that name.",
+ cache_dir_path);
else
log_error_errno(errno, "Failed to change to AppArmor profile 'systemd': %m");
return 0;
#include <security/pam_misc.h>
#endif
-#if HAVE_APPARMOR
-#include <sys/apparmor.h>
-#endif
-
#include "sd-messages.h"
-#if HAVE_APPARMOR
#include "apparmor-util.h"
-#endif
#include "argv-util.h"
#include "ask-password-api.h"
#include "barrier.h"
use_smack = mac_smack_use();
#endif
#if HAVE_APPARMOR
- use_apparmor = mac_apparmor_use();
+ if (mac_apparmor_use()) {
+ r = dlopen_libapparmor();
+ if (r < 0 && !ERRNO_IS_NEG_NOT_SUPPORTED(r))
+ log_warning_errno(r, "Failed to load libapparmor, ignoring: %m");
+ use_apparmor = r >= 0;
+ }
#endif
}
#if HAVE_APPARMOR
if (use_apparmor && context->apparmor_profile) {
- r = aa_change_onexec(context->apparmor_profile);
+ r = ASSERT_PTR(sym_aa_change_onexec)(context->apparmor_profile);
if (r < 0 && !context->apparmor_profile_ignore) {
*exit_status = EXIT_APPARMOR_PROFILE;
return log_exec_error_errno(context,
#include "fileio.h"
#include "parse-util.h"
+#if HAVE_APPARMOR
+static void *libapparmor_dl = NULL;
+
+DLSYM_PROTOTYPE(aa_change_onexec) = NULL;
+DLSYM_PROTOTYPE(aa_change_profile) = NULL;
+DLSYM_PROTOTYPE(aa_features_new_from_kernel) = NULL;
+DLSYM_PROTOTYPE(aa_features_unref) = NULL;
+DLSYM_PROTOTYPE(aa_policy_cache_dir_path_preview) = NULL;
+DLSYM_PROTOTYPE(aa_policy_cache_new) = NULL;
+DLSYM_PROTOTYPE(aa_policy_cache_replace_all) = NULL;
+DLSYM_PROTOTYPE(aa_policy_cache_unref) = NULL;
+
+int dlopen_libapparmor(void) {
+ ELF_NOTE_DLOPEN("apparmor",
+ "Support for AppArmor policies",
+ ELF_NOTE_DLOPEN_PRIORITY_RECOMMENDED,
+ "libapparmor.so.1");
+
+ return dlopen_many_sym_or_warn(
+ &libapparmor_dl,
+ "libapparmor.so.1",
+ LOG_DEBUG,
+ DLSYM_ARG(aa_change_onexec),
+ DLSYM_ARG(aa_change_profile),
+ DLSYM_ARG(aa_features_new_from_kernel),
+ DLSYM_ARG(aa_features_unref),
+ DLSYM_ARG(aa_policy_cache_dir_path_preview),
+ DLSYM_ARG(aa_policy_cache_new),
+ DLSYM_ARG(aa_policy_cache_replace_all),
+ DLSYM_ARG(aa_policy_cache_unref));
+}
+#endif
+
bool mac_apparmor_use(void) {
static int cached_use = -1;
projects / thirdparty / systemd.git / commitdiff
