[#599,!320] Protect against null ptr dereferencing in HTTP log messages.

As a result of review.

diff --git a/src/lib/http/client.cc b/src/lib/http/client.cc
index 91359e47f9ee8519ffa01a2d2e61dab975ccc26b..971e493e11a3238d9323b8a1ca492f10d01b73ac 100644 (file)
--- a/src/lib/http/client.cc
+++ b/src/lib/http/client.cc
@@ -587,7 +587,8 @@ Connection::terminate(const boost::system::error_code& ec,
             LOG_DEBUG(http_logger, isc::log::DBGLVL_TRACE_BASIC_DATA,
                       HTTP_SERVER_RESPONSE_RECEIVED_DETAILS)
                 .arg(url_.toText())
-                .arg(parser_->getBufferAsString(MAX_LOGGED_MESSAGE_SIZE));
+                .arg((parser_ ? parser_->getBufferAsString(MAX_LOGGED_MESSAGE_SIZE)
+                      : "[HttpResponseParser is null]"));
 
         } else {
             std::string err = parsing_error.empty() ? ec.message() : parsing_error;
@@ -603,7 +604,8 @@ Connection::terminate(const boost::system::error_code& ec,
                 LOG_DEBUG(http_logger, isc::log::DBGLVL_TRACE_BASIC_DATA,
                           HTTP_BAD_SERVER_RESPONSE_RECEIVED_DETAILS)
                     .arg(url_.toText())
-                    .arg(parser_->getBufferAsString());
+                    .arg((parser_ ? parser_->getBufferAsString()
+                          : "[HttpResponseParser is null]"));
             }
         }