]> git.ipfire.org Git - thirdparty/ipxe.git/commitdiff
[sis190] Avoid NULL pointer dereference
authorMichael Brown <mcb30@ipxe.org>
Wed, 22 Mar 2017 14:12:56 +0000 (16:12 +0200)
committerMichael Brown <mcb30@ipxe.org>
Wed, 22 Mar 2017 14:12:56 +0000 (16:12 +0200)
Signed-off-by: Michael Brown <mcb30@ipxe.org>
src/drivers/net/sis190.c

index 81f3d9844879d73405101b402063b8e1ac8468d9..b92e95f2a889d84f5bac7268d7c65c6a6cfca742 100644 (file)
@@ -965,8 +965,8 @@ static int sis190_get_mac_addr_from_apc(struct pci_device *pdev,
 
        list_for_each_entry(d, &(pdev->dev.siblings), siblings) {
                unsigned int i;
-               isa_bridge = container_of(d, struct pci_device, dev);
                for(i = 0; i < sis190_isa_bridge_driver.id_count; i++) {
+                       isa_bridge = container_of(d, struct pci_device, dev);
                        if(isa_bridge->vendor ==
                             sis190_isa_bridge_driver.ids[i].vendor
                             && isa_bridge->device ==