]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
nfsd: remove obsolete comment from nfs4_alloc_stid
authorJeff Layton <jlayton@kernel.org>
Mon, 3 Mar 2025 17:26:01 +0000 (12:26 -0500)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 10 Mar 2025 13:11:12 +0000 (09:11 -0400)
idr_alloc_cyclic() is what guarantees that now, not this long-gone trick.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4state.c

index b68bc3f12a8c29904e6bdd2b5a1e4ed6418104e3..e51c310bd11152e724b0d374556bea9899fc8428 100644 (file)
@@ -946,15 +946,6 @@ struct nfs4_stid *nfs4_alloc_stid(struct nfs4_client *cl, struct kmem_cache *sla
        spin_lock_init(&stid->sc_lock);
        INIT_LIST_HEAD(&stid->sc_cp_list);
 
-       /*
-        * It shouldn't be a problem to reuse an opaque stateid value.
-        * I don't think it is for 4.1.  But with 4.0 I worry that, for
-        * example, a stray write retransmission could be accepted by
-        * the server when it should have been rejected.  Therefore,
-        * adopt a trick from the sctp code to attempt to maximize the
-        * amount of time until an id is reused, by ensuring they always
-        * "increase" (mod INT_MAX):
-        */
        return stid;
 out_free:
        kmem_cache_free(slab, stid);