]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: renesas: rz-ssi: Add runtime PM support
authorClaudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Tue, 10 Dec 2024 17:09:44 +0000 (19:09 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 11 Dec 2024 13:24:05 +0000 (13:24 +0000)
Add runtime PM support to the ssi driver. This assert/de-assert the
reset lines on runtime suspend/resume. Along with it the de-assertion of
the reset line from probe function was removed as it is not necessary
anymore.

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Link: https://patch.msgid.link/20241210170953.2936724-16-claudiu.beznea.uj@bp.renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/renesas/rz-ssi.c

index eebf2d647ef20c775a2b76dcadf4e7225a19a4ff..34c2e22b5a67036364321df399bd02e840b4930d 100644 (file)
@@ -1139,14 +1139,13 @@ static int rz_ssi_probe(struct platform_device *pdev)
                goto err_release_dma_chs;
        }
 
-       reset_control_deassert(ssi->rstc);
        /* Default 0 for power saving. Can be overridden via sysfs. */
        pm_runtime_set_autosuspend_delay(dev, 0);
        pm_runtime_use_autosuspend(dev);
        ret = devm_pm_runtime_enable(dev);
        if (ret < 0) {
                dev_err(dev, "Failed to enable runtime PM!\n");
-               goto err_reset;
+               goto err_release_dma_chs;
        }
 
        ret = devm_snd_soc_register_component(dev, &rz_ssi_soc_component,
@@ -1154,13 +1153,11 @@ static int rz_ssi_probe(struct platform_device *pdev)
                                              ARRAY_SIZE(rz_ssi_soc_dai));
        if (ret < 0) {
                dev_err(dev, "failed to register snd component\n");
-               goto err_reset;
+               goto err_release_dma_chs;
        }
 
        return 0;
 
-err_reset:
-       reset_control_assert(ssi->rstc);
 err_release_dma_chs:
        rz_ssi_release_dma_channels(ssi);
 
@@ -1182,10 +1179,29 @@ static const struct of_device_id rz_ssi_of_match[] = {
 };
 MODULE_DEVICE_TABLE(of, rz_ssi_of_match);
 
+static int rz_ssi_runtime_suspend(struct device *dev)
+{
+       struct rz_ssi_priv *ssi = dev_get_drvdata(dev);
+
+       return reset_control_assert(ssi->rstc);
+}
+
+static int rz_ssi_runtime_resume(struct device *dev)
+{
+       struct rz_ssi_priv *ssi = dev_get_drvdata(dev);
+
+       return reset_control_deassert(ssi->rstc);
+}
+
+static const struct dev_pm_ops rz_ssi_pm_ops = {
+       RUNTIME_PM_OPS(rz_ssi_runtime_suspend, rz_ssi_runtime_resume, NULL)
+};
+
 static struct platform_driver rz_ssi_driver = {
        .driver = {
                .name   = "rz-ssi-pcm-audio",
                .of_match_table = rz_ssi_of_match,
+               .pm = pm_ptr(&rz_ssi_pm_ops),
        },
        .probe          = rz_ssi_probe,
        .remove         = rz_ssi_remove,