]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: i2c: imx214: Fix uninitialized variable in imx214_set_ctrl()
authorDan Carpenter <dan.carpenter@linaro.org>
Tue, 18 Feb 2025 13:05:50 +0000 (16:05 +0300)
committerHans Verkuil <hverkuil@xs4all.nl>
Tue, 4 Mar 2025 12:35:32 +0000 (13:35 +0100)
You can't pass uninitialized "ret" variables to cci_write().  It has to
start as zero.

Fixes: 4f0aeba4f155 ("media: i2c: imx214: Convert to CCI register access helpers")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: André Apitzsch <git@apitzsch.eu>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/i2c/imx214.c

index 4f320660c91c4c102b35067fe3451044eeb5531a..dd7bc45523d8b5fcb3ec95728a6d32c4fddede72 100644 (file)
@@ -795,7 +795,7 @@ static int imx214_set_ctrl(struct v4l2_ctrl *ctrl)
                                             struct imx214, ctrls);
        const struct v4l2_mbus_framefmt *format = NULL;
        struct v4l2_subdev_state *state;
-       int ret;
+       int ret = 0;
 
        if (ctrl->id == V4L2_CID_VBLANK) {
                int exposure_max, exposure_def;