]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mac80211: remove BUG() when interface type is invalid
authorLuca Coelho <luciano.coelho@intel.com>
Sun, 29 Oct 2017 09:51:10 +0000 (11:51 +0200)
committerSasha Levin <alexander.levin@microsoft.com>
Wed, 23 May 2018 01:33:47 +0000 (21:33 -0400)
[ Upstream commit c7976f5272486e4ff406014c4b43e2fa3b70b052 ]

In the ieee80211_setup_sdata() we check if the interface type is valid
and, if not, call BUG().  This should never happen, but if there is
something wrong with the code, it will not be caught until the bug
happens when an interface is being set up.  Calling BUG() is too
extreme for this and a WARN_ON() would be better used instead.  Change
that.

Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
net/mac80211/iface.c

index 6e89ab8eac449eec06e144c653adc655ff1e5686..83aade4778553d61d60ba351f5ee732d2421e59d 100644 (file)
@@ -1418,7 +1418,7 @@ static void ieee80211_setup_sdata(struct ieee80211_sub_if_data *sdata,
                break;
        case NL80211_IFTYPE_UNSPECIFIED:
        case NUM_NL80211_IFTYPES:
-               BUG();
+               WARN_ON(1);
                break;
        }