]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
proc: array: drop stale FIXME about RCU in task_sig()
authorJaime Saguillo Revilla <jaime.saguillo@gmail.com>
Sun, 15 Feb 2026 12:45:11 +0000 (12:45 +0000)
committerAndrew Morton <akpm@linux-foundation.org>
Sat, 28 Mar 2026 04:19:32 +0000 (21:19 -0700)
task_sig() already wraps the SigQ rlimit read in an explicit RCU read-side
critical section.  Drop the stale FIXME comment and keep using
task_ucounts() for the ucounts access.

No functional change.

Link: https://lkml.kernel.org/r/20260215124511.14227-1-jaime.saguillo@gmail.com
Signed-off-by: Jaime Saguillo Revilla <jaime.saguillo@gmail.com>
Acked-by: Oleg Nesterov <oleg@redhat.com>
Cc: Christian Brauner <brauner@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/proc/array.c

index f447e734612aa19896ada70ee6188062dd8163e6..90fb0c6b5f99fe2e5337a4e92ac99a1b4f15c90b 100644 (file)
@@ -280,7 +280,7 @@ static inline void task_sig(struct seq_file *m, struct task_struct *p)
                blocked = p->blocked;
                collect_sigign_sigcatch(p, &ignored, &caught);
                num_threads = get_nr_threads(p);
-               rcu_read_lock();  /* FIXME: is this correct? */
+               rcu_read_lock();
                qsize = get_rlimit_value(task_ucounts(p), UCOUNT_RLIMIT_SIGPENDING);
                rcu_read_unlock();
                qlim = task_rlimit(p, RLIMIT_SIGPENDING);