]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4-torture: Reduce flapping in SambaToolDrsTests.test_samba_tool_replicate_local
authorAndrew Bartlett <abartlet@samba.org>
Thu, 31 Oct 2019 17:53:56 +0000 (06:53 +1300)
committerKarolin Seeger <kseeger@samba.org>
Fri, 29 Nov 2019 10:55:44 +0000 (11:55 +0100)
This test often flaps in Samba 4.9 (where more tests and DCs run in the environment)
with obj_1 being 3.  This is quite OK, we just need to see some changes get
replicated, not 0 changes.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
(cherry picked from commit 4ae0f9ce0f5ada99cf1d236377e5a1234c879ae3)

source4/torture/drs/python/samba_tool_drs.py

index 29c6016471c14d20cdf5f2b8b4c3836470b45f47..74fa433ce594747fb58421c6c5d14b08ecf4490e 100644 (file)
@@ -209,6 +209,7 @@ class SambaToolDrsTests(drs_base.DrsBaseTestCase):
         self._disable_inbound_repl(self.dnsname_dc1)
         self._disable_inbound_repl(self.dnsname_dc2)
 
+        self._net_drs_replicate(DC=self.dnsname_dc2, fromDC=self.dnsname_dc1)
         self._net_drs_replicate(DC=self.dnsname_dc1, fromDC=self.dnsname_dc2)
 
         # add an object with link on dc1
@@ -231,7 +232,7 @@ class SambaToolDrsTests(drs_base.DrsBaseTestCase):
 
         (obj_1, link_1) = get_num_obj_links(out)
 
-        self.assertEqual(obj_1, 2)
+        self.assertGreaterEqual(obj_1, 2)
         self.assertEqual(link_1, 1)
 
         # pull that change with --local into local db from dc2: shouldn't send link or object