]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: plip: fix break; causing plip to never transmit
authorJakub Boehm <boehm.jakub@gmail.com>
Tue, 15 Oct 2024 15:16:04 +0000 (17:16 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 1 Nov 2024 00:52:36 +0000 (01:52 +0100)
[ Upstream commit f99cf996ba5a315f8b9f13cc21dff0604a0eb749 ]

Since commit
  71ae2cb30531 ("net: plip: Fix fall-through warnings for Clang")

plip was not able to send any packets, this patch replaces one
unintended break; with fallthrough; which was originally missed by
commit 9525d69a3667 ("net: plip: mark expected switch fall-throughs").

I have verified with a real hardware PLIP connection that everything
works once again after applying this patch.

Fixes: 71ae2cb30531 ("net: plip: Fix fall-through warnings for Clang")
Signed-off-by: Jakub Boehm <boehm.jakub@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Message-ID: <20241015-net-plip-tx-fix-v1-1-32d8be1c7e0b@gmail.com>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/plip/plip.c

index b1776116f9f7d7c07405776f8e81fafb1004900d..bea741afe78be449b375928a34630f2c55891317 100644 (file)
@@ -811,7 +811,7 @@ plip_send_packet(struct net_device *dev, struct net_local *nl,
                                return HS_TIMEOUT;
                        }
                }
-               break;
+               fallthrough;
 
        case PLIP_PK_LENGTH_LSB:
                if (plip_send(nibble_timeout, dev,