Warn if signal hides member in base class

diff --git a/vala/valasignal.vala b/vala/valasignal.vala
index c58e160e1053d770da0a8e5144dec2ead023fb2c..207d8f73742cf97ea7938477130461d7ec8506c3 100644 (file)
--- a/vala/valasignal.vala
+++ b/vala/valasignal.vala
@@ -265,6 +265,12 @@ public class Vala.Signal : Member, Lockable {
                        cl.add_hidden_method (default_handler);
                        default_handler.check (analyzer);
                }
+
+
+               if (!external_package && !hides && get_hidden_member () != null) {
+                       Report.warning (source_reference, "%s hides inherited signal `%s'. Use the `new' keyword if hiding was intentional".printf (get_full_name (), get_hidden_member ().get_full_name ()));
+               }
+
                return !error;
        }
 }