]> git.ipfire.org Git - thirdparty/openwrt.git/commitdiff
realtek: phy: replace hard coded pages 30/31 with define 21716/head
authorMarkus Stockhausen <markus.stockhausen@gmx.de>
Mon, 26 Jan 2026 13:34:07 +0000 (14:34 +0100)
committerHauke Mehrtens <hauke@hauke-m.de>
Tue, 27 Jan 2026 23:28:15 +0000 (00:28 +0100)
Some of the code forgot to use the register defines for page
selection. Replace the hard coded values with their define.

Signed-off-by: Markus Stockhausen <markus.stockhausen@gmx.de>
Link: https://github.com/openwrt/openwrt/pull/21716
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
target/linux/realtek/files-6.12/drivers/net/phy/rtl83xx-phy.c

index 475a628de9f85c92b25d08210041ea3069d8ded5..428fdb7d538ba3054add3cdf8ab8cab18e7de9f4 100644 (file)
@@ -127,18 +127,18 @@ static int rtl821x_match_phy_device(struct phy_device *phydev)
         * during detection.
         */
 
-       oldpage = mdiobus_read(bus, addr, 0x1f);
-       oldxpage = mdiobus_read(bus, addr, 0x1e);
+       oldpage = mdiobus_read(bus, addr, RTL821x_PAGE_SELECT);
+       oldxpage = mdiobus_read(bus, addr, RTL821x_EXT_PAGE_SELECT);
 
-       mdiobus_write(bus, addr, 0x1e, 0x8);
-       mdiobus_write(bus, addr, 0x1f, 0x278);
+       mdiobus_write(bus, addr, RTL821x_EXT_PAGE_SELECT, 0x8);
+       mdiobus_write(bus, addr, RTL821x_PAGE_SELECT, 0x278);
        mdiobus_write(bus, addr, 0x12, 0x455);
-       mdiobus_write(bus, addr, 0x1f, 0x260);
+       mdiobus_write(bus, addr, RTL821x_PAGE_SELECT, 0x260);
        chip_mode = mdiobus_read(bus, addr, 0x12);
        dev_dbg(&phydev->mdio.dev, "got RTL8218B/RTL8214Fx chip mode %04x\n", chip_mode);
 
-       mdiobus_write(bus, addr, 0x1e, oldxpage);
-       mdiobus_write(bus, addr, 0x1f, oldpage);
+       mdiobus_write(bus, addr, RTL821x_EXT_PAGE_SELECT, oldxpage);
+       mdiobus_write(bus, addr, RTL821x_PAGE_SELECT, oldpage);
 
        /* no values while reading the 5th port during 5-8th port detection of RTL8218B */
        if (!chip_mode)