backport: re PR fortran/60450 (ICE with SHAPE intrinsic)

2014-03-09  Janus Weil  <janus@gcc.gnu.org>

	Backport from 4.8
	2014-03-08  Janus Weil  <janus@gcc.gnu.org>

	PR fortran/60450
	* simplify.c (gfc_simplify_shape): Only clear shape if it was really
	created successfully.

2014-03-09  Janus Weil  <janus@gcc.gnu.org>

	Backport from 4.8
	2014-03-08  Janus Weil  <janus@gcc.gnu.org>

	PR fortran/60450
	* gfortran.dg/shape_8.f90: New.

From-SVN: r208443

diff --git a/gcc/fortran/ChangeLog b/gcc/fortran/ChangeLog
index 2763fb223f0ddbe067fcdc51ecae756c44f00eed..928e0397d93e6ba65bfa20cc2f415fdd1353416a 100644 (file)
--- a/gcc/fortran/ChangeLog
+++ b/gcc/fortran/ChangeLog
@@ -1,3 +1,12 @@
+2014-03-09  Janus Weil  <janus@gcc.gnu.org>
+
+       Backport from 4.8
+       2014-03-08  Janus Weil  <janus@gcc.gnu.org>
+
+       PR fortran/60450
+       * simplify.c (gfc_simplify_shape): Only clear shape if it was really
+       created successfully.
+
 2014-03-02  Mikael Morin  <mikael@gcc.gnu.org>
 
        PR fortran/60341

diff --git a/gcc/fortran/simplify.c b/gcc/fortran/simplify.c
index 515528d489b914f3e577679f25247db1bd53ffe3..c9fd122f6e38de8a3737e29e684b312efd039316 100644 (file)
--- a/gcc/fortran/simplify.c
+++ b/gcc/fortran/simplify.c
@@ -5518,7 +5518,7 @@ gfc_simplify_shape (gfc_expr *source, gfc_expr *kind)
       if (e == &gfc_bad_expr || range_check (e, "SHAPE") == &gfc_bad_expr)
        {
          gfc_free_expr (result);
-         if (t)
+         if (t == SUCCESS)
            gfc_clear_shape (shape, source->rank);
          return &gfc_bad_expr;
        }
@@ -5526,7 +5526,7 @@ gfc_simplify_shape (gfc_expr *source, gfc_expr *kind)
       gfc_constructor_append_expr (&result->value.constructor, e, NULL);
     }
 
-  if (t)
+  if (t == SUCCESS)
     gfc_clear_shape (shape, source->rank);
 
   return result;

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index b2e4e614bcad2a6235675ef14a1fb6bafc283c27..0058553c294483a91737dfce078e658286394d64 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,11 @@
+2014-03-09  Janus Weil  <janus@gcc.gnu.org>
+
+       Backport from 4.8
+       2014-03-08  Janus Weil  <janus@gcc.gnu.org>
+
+       PR fortran/60450
+       * gfortran.dg/shape_8.f90: New.
+
 2014-03-02  Mikael Morin  <mikael@gcc.gnu.org>
 
        PR fortran/60341

diff --git a/gcc/testsuite/gfortran.dg/shape_8.f90 b/gcc/testsuite/gfortran.dg/shape_8.f90
new file mode 100644 (file)
index 0000000..edeb5fd
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/shape_8.f90
@@ -0,0 +1,10 @@
+! { dg-do compile }
+!
+! PR 60450: [4.7/4.8 Regression] ICE with SHAPE intrinsic
+!
+! Contributed by Dave Allured <dave.allured@noaa.gov>
+
+  real, allocatable :: x(:,:)
+  allocate (x(3,2), source=99.)
+  print *, shape (x / 10.0)
+end