]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
Print checkKey() error messages in signer tests
authorFred Morcos <fred.morcos@open-xchange.com>
Tue, 22 Nov 2022 09:55:14 +0000 (10:55 +0100)
committerFred Morcos <fred.morcos@open-xchange.com>
Tue, 10 Jan 2023 14:50:35 +0000 (15:50 +0100)
pdns/test-signers.cc

index 6e27096bb8ac3d64543d4a22d4802acdae9c4308..523eb3a97117324534918e539ff148a53f6d5614 100644 (file)
@@ -359,7 +359,15 @@ static void test_generic_signer(std::shared_ptr<DNSCryptoKeyEngine> dcke, DNSKEY
 {
   BOOST_CHECK_EQUAL(dcke->getAlgorithm(), signer.algorithm);
   BOOST_CHECK_EQUAL(dcke->getBits(), signer.bits);
-  BOOST_CHECK_EQUAL(dcke->checkKey(nullptr), true);
+
+  vector<string> errorMessages{};
+  BOOST_CHECK_EQUAL(dcke->checkKey(&errorMessages), true);
+  if (!errorMessages.empty()) {
+    BOOST_TEST_MESSAGE("Errors from " + dcke->getName() + " checkKey()");
+    for (auto& errorMessage : errorMessages) {
+      BOOST_TEST_MESSAGE("  " + errorMessage);
+    }
+  }
 
   BOOST_CHECK_EQUAL(drc.d_algorithm, signer.algorithm);