s4:kdc: Check result of dom_sid_parse()

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/source4/kdc/pac-glue.c b/source4/kdc/pac-glue.c
index 1f4e4ecf6657063c9fd62474c48a8abde5724734..1a551191e59d4a6c85739b66656639013a4d8b2b 100644 (file)
--- a/source4/kdc/pac-glue.c
+++ b/source4/kdc/pac-glue.c
@@ -840,7 +840,9 @@ static NTSTATUS samba_add_asserted_identity(enum samba_asserted_identity ai,
                return NT_STATUS_OK;
        }
 
-       dom_sid_parse(sid_str, &ai_sid);
+       if (!dom_sid_parse(sid_str, &ai_sid)) {
+               return NT_STATUS_UNSUCCESSFUL;
+       }
 
        return add_sid_to_array_attrs_unique(
                user_info_dc,