Initialize rather than memcpy() (CID #1508486) (#4707)

diff --git a/src/lib/server/tmpl_eval.c b/src/lib/server/tmpl_eval.c
index 20fce154b926ab5863a8b1f638b3d0c606fc87bd..2edb65cd25aa12a7d9c001219d993ff4b0423770 100644 (file)
--- a/src/lib/server/tmpl_eval.c
+++ b/src/lib/server/tmpl_eval.c
@@ -668,7 +668,7 @@ ssize_t _tmpl_to_atype(TALLOC_CTX *ctx, void *out,
        fr_value_box_t          from_cast;
 
        fr_pair_t               *vp = NULL;
-       fr_value_box_t          value;
+       fr_value_box_t          value = (fr_value_box_t){};
        bool                    needs_dup = false;
 
        ssize_t                 slen = -1;
@@ -678,8 +678,6 @@ ssize_t _tmpl_to_atype(TALLOC_CTX *ctx, void *out,
 
        TMPL_VERIFY(vpt);
 
-       memset(&value, 0, sizeof(value));
-
        switch (vpt->type) {
        case TMPL_TYPE_UNRESOLVED:
                RDEBUG4("EXPAND TMPL UNRESOLVED");