ntfs: remove unnecessary NULL checks before kfree

NULL check before kfree() is unnecessary and triggers coccinelle warnings.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>

diff --git a/fs/ntfs/logfile.c b/fs/ntfs/logfile.c
index d3f25d8e29f9d28b956cce21fe52655631a935e7..9df8c3095ca48d5675d98b71558bbdeb280b2258 100644 (file)
--- a/fs/ntfs/logfile.c
+++ b/fs/ntfs/logfile.c
@@ -622,8 +622,7 @@ is_empty:
        ntfs_debug("Done.");
        return true;
 err_out:
-       if (rstr1_ph)
-               kvfree(rstr1_ph);
+       kvfree(rstr1_ph);
        return false;
 }
 

diff --git a/fs/ntfs/super.c b/fs/ntfs/super.c
index 312acb41c2ed5d9fdce9873705d276b056d0efb0..2a5ad7d56bc268251fa89ab03079b030fd02c3f9 100644 (file)
--- a/fs/ntfs/super.c
+++ b/fs/ntfs/super.c
@@ -1634,7 +1634,7 @@ static void ntfs_volume_free(struct ntfs_volume *vol)
                vol->upcase = NULL;
        }
 
-       if (!ntfs_nr_upcase_users && default_upcase) {
+       if (!ntfs_nr_upcase_users) {
                kvfree(default_upcase);
                default_upcase = NULL;
        }
@@ -1649,8 +1649,7 @@ static void ntfs_volume_free(struct ntfs_volume *vol)
 
        unload_nls(vol->nls_map);
 
-       if (vol->lcn_empty_bits_per_page)
-               kvfree(vol->lcn_empty_bits_per_page);
+       kvfree(vol->lcn_empty_bits_per_page);
        kfree(vol->volume_label);
        kfree(vol);
 }