tree-wide: fix compilation with-Wstrict-prototypes -Wold-style-definition

Fixes: #3630
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

diff --git a/src/lxc/log.c b/src/lxc/log.c
index 824c3f5fa6ae32d26e538a95ee31396dcf68ba8b..6c75744534e177a5c6baae955b6727657a419ae2 100644 (file)
--- a/src/lxc/log.c
+++ b/src/lxc/log.c
@@ -82,7 +82,7 @@ static int lxc_log_priority_to_syslog(int priority)
        return LOG_NOTICE;
 }
 
-static const char *lxc_log_get_container_name()
+static const char *lxc_log_get_container_name(void)
 {
 #ifndef NO_LXC_CONF
        if (current_config && !log_vmname)
@@ -814,7 +814,7 @@ inline const char *lxc_log_get_prefix(void)
        return log_prefix;
 }
 
-inline void lxc_log_options_no_override()
+inline void lxc_log_options_no_override(void)
 {
        lxc_quiet_specified = 1;
        lxc_loglevel_specified = 1;

diff --git a/src/lxc/lsm/apparmor.c b/src/lxc/lsm/apparmor.c
index 21945b8266b1c9c88a993707f8ab63d45a26aa4c..ec946ad18444fd7e8dc957fce69bb2788c5d5005 100644 (file)
--- a/src/lxc/lsm/apparmor.c
+++ b/src/lxc/lsm/apparmor.c
@@ -588,7 +588,7 @@ static bool file_is_yes(const char *path)
        return rd >= 4 && strncmp(buf, "yes\n", 4) == 0;
 }
 
-static bool apparmor_can_stack()
+static bool apparmor_can_stack(void)
 {
        int major, minor, scanned;
        FILE *f;

diff --git a/src/lxc/tools/arguments.c b/src/lxc/tools/arguments.c
index dfed2a9ab91fcaf137d30b641850ef66f0f01b9d..447031fc02add2b8f104679205c9bb65a6227ca7 100644 (file)
--- a/src/lxc/tools/arguments.c
+++ b/src/lxc/tools/arguments.c
@@ -116,7 +116,7 @@ __noreturn static void print_usage_exit(const struct option longopts[],
        exit(EXIT_SUCCESS);
 }
 
-__noreturn static void print_version_exit()
+__noreturn static void print_version_exit(void)
 {
        printf("%s\n", lxc_get_version());
        exit(EXIT_SUCCESS);

diff --git a/src/lxc/tools/lxc_copy.c b/src/lxc/tools/lxc_copy.c
index db26094ad5797e266b5ebe1d6a38a77b87d66af5..c406929272764fb00e8541b7d130be482f5a597e 100644 (file)
--- a/src/lxc/tools/lxc_copy.c
+++ b/src/lxc/tools/lxc_copy.c
@@ -509,7 +509,7 @@ static int do_clone_task(struct lxc_container *c, enum task task, int flags,
        return ret;
 }
 
-static void free_mnts()
+static void free_mnts(void)
 {
        unsigned int i;
        struct mnts *n = NULL;

diff --git a/src/lxc/utils.c b/src/lxc/utils.c
index 1e0b38e121b63f2da4ef9cf965124cb294b6cc05..bb7074cca6e54f001f77eeabd7ebec95334d533b 100644 (file)
--- a/src/lxc/utils.c
+++ b/src/lxc/utils.c
@@ -238,7 +238,7 @@ int mkdir_p(const char *dir, mode_t mode)
        return 0;
 }
 
-char *get_rundir()
+char *get_rundir(void)
 {
        __do_free char *rundir = NULL;
        char *static_rundir;

diff --git a/src/tests/cgpath.c b/src/tests/cgpath.c
index 5a7d6839c4eff43c094621f36d1c45b9b916b695..5e3eb56c336940083071edab523e80bd6b582df6 100644 (file)
--- a/src/tests/cgpath.c
+++ b/src/tests/cgpath.c
@@ -173,7 +173,7 @@ out1:
        return ret;
 }
 
-int main()
+int main(int argc, char *argv[])
 {
        int ret = EXIT_FAILURE;
 

diff --git a/src/tests/lxcpath.c b/src/tests/lxcpath.c
index b5141b46446950671c5159c8ecb026cd40559a26..64cc57b64dc698fa19a03962f14f761961f64fc1 100644 (file)
--- a/src/tests/lxcpath.c
+++ b/src/tests/lxcpath.c
@@ -33,7 +33,7 @@
        fprintf(stderr, "%d: %s\n", __LINE__, x); \
 } while (0)
 
-int main()
+int main(int argc, char *argv[])
 {
        struct lxc_container *c;
        const char *p1, *p2;

diff --git a/src/tests/mount_injection.c b/src/tests/mount_injection.c
index 3c44d4014f11c1d40c9315cc75501630e5253233..c054558800955df342f76ed9a5b4eb836ddc6c60 100644 (file)
--- a/src/tests/mount_injection.c
+++ b/src/tests/mount_injection.c
@@ -371,13 +371,13 @@ out:
        return ret;
 }
 
-static int do_priv_container_test()
+static int do_priv_container_test(void)
 {
        const char *config_items[] = {"lxc.mount.auto", "shmounts:/tmp/mount_injection_test", NULL};
        return perform_container_test(NAME"privileged", config_items);
 }
 
-static int do_unpriv_container_test()
+static int do_unpriv_container_test(void)
 {
        const char *config_items[] = {
                "lxc.mount.auto", "shmounts:/tmp/mount_injection_test",