]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4:torture: Remove assertion that primary group is not duplicated in user_info_dc
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Thu, 15 Dec 2022 23:47:02 +0000 (12:47 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Wed, 8 Feb 2023 00:03:40 +0000 (00:03 +0000)
This assertion is one we will be breaking shortly.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/torture/rpc/remote_pac.c

index 28b9f1be52341e1e1d325ab5b39b06eb5ed14b95..214ecd0ff6c784fac2fe9e2fe8cc1e8c56786bd8 100644 (file)
@@ -979,13 +979,6 @@ static bool test_S4U2Self(struct torture_context *tctx,
        status = check_primary_group_in_validation(tmp_ctx, r.in.validation_level, r.out.validation);
        torture_assert_ntstatus_ok(tctx, status, "check_primary_group_in_validation failed");
 
-       /* Check that the primary group is not duplicated in user_info_dc SID array */
-       for (i = 2; i < netlogon_user_info_dc->num_sids; i++) {
-               torture_assert(tctx, !dom_sid_equal(&netlogon_user_info_dc->sids[1].sid,
-                                                   &netlogon_user_info_dc->sids[i].sid),
-                              "Duplicate PrimaryGroupId in return SID array");
-       }
-
        torture_assert_str_equal(tctx, netlogon_user_info_dc->info->account_name == NULL ? "" : netlogon_user_info_dc->info->account_name,
                                 kinit_session_info->info->account_name, "Account name differs for kinit-based PAC");
        torture_assert_str_equal(tctx,netlogon_user_info_dc->info->account_name == NULL ? "" : netlogon_user_info_dc->info->account_name,